fix: use upgraded require optional #1743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Having another stab at #1682
Why:
The end goal is to not bundle/require
typeormandnodemailer, if someone doesn't use any of these in their project.How:
I took
require_optionalas a base, but published my own version under@balazsorban/require-optional. The difference is that it will use the now seemingly established fieldspeerDependenciesandpeerDependenciesMeta, instead ofpeerOptionalDependencies, which doesn't appear to be anywhere. In fact, googling it will point to one of this repository's issue with mongodb!Side note, mongodb themselves decided to turn away from
peerOptionalDependencies: https://jira.mongodb.org/browse/NODE-2867Checklist: